Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update localisations #2582

Merged
merged 3 commits into from
Jun 17, 2024
Merged

Update localisations #2582

merged 3 commits into from
Jun 17, 2024

Conversation

Eitot
Copy link
Contributor

@Eitot Eitot commented Jun 15, 2024

This adds missing localisable strings to the base localisation and updates the Dutch and German localisations.

Fixes # (issue)

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

macOS version tested: [place version here]

"Application Name" = "App-Name";

/* No comment provided by engineer. */
"Application Version" = "App-Version";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason "Application Name" and "Application Version" use shortened names like this? This seems to be English.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess same is done with OS-version so I assume it's intentional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apple uses the short form app instead of applicatie in Dutch, across the system. The Applications directory is called Apps too, so I chose this for consistency.

Apple uses the short form in German as well, but not as consistently as in Dutch. I chose this here mainly to keep the field short, but it may be reconsidered depending on how it looks (Anwendungsname or Name der Anwendung would be the substitute), as the field for CPU speed is long too.

"CPU Subtype" = "CPU-Untertyp";

/* No comment provided by engineer. */
"CPU Type" = "CPU-Typ";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intentional the 'e' is left out?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, same is done with CPU Subtype, so I assume it is.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in German the word for type has no 'e' at the end.

@zorgiepoo zorgiepoo added this to the 2.7 milestone Jun 17, 2024
@zorgiepoo zorgiepoo merged commit 3f93bf0 into sparkle-project:2.x Jun 17, 2024
2 checks passed
@zorgiepoo
Copy link
Member

Thanks.

@Eitot Eitot deleted the localizations branch June 17, 2024 14:04
@1024jp 1024jp mentioned this pull request Jun 22, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants