Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require signing validation for apple archives before extraction #2588

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented Jun 20, 2024

Because .aar support is new and not a widely used format, require validating them before extraction for now (similar to delta based updates). This also means this archive format cannot presently be used for key rotation. Strengthening the validation later will be harder to do if people start to rely on the format, so better to try this now than later.

Related to #2586

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Tested aar extraction only works when updating aar archived app when signature is valid with sparkle-cli
Tested policy for updating zipped based app is still the same (more lax).

macOS version tested: 14.5 (23F79)

@zorgiepoo zorgiepoo added this to the 2.7 milestone Jun 20, 2024
@zorgiepoo zorgiepoo merged commit 1b6565d into 2.x Jun 20, 2024
2 checks passed
@zorgiepoo zorgiepoo deleted the aar-prevalidate branch June 20, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant