Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload temporary sparkle_dist tarball instead of sparkle-dist #2681

Merged
merged 1 commit into from
Dec 27, 2024

Conversation

zorgiepoo
Copy link
Member

@zorgiepoo zorgiepoo commented Dec 27, 2024

The release workflow on GitHub uploads files that match "Sparkle-*" which apparently now includes sparkle-dist.tar.xz even though it's not capitalized. Rename the file to sparkle_dist to work around this.

Misc Checklist

  • My change requires a documentation update on Sparkle's website repository
  • My change requires changes to generate_appcast, generate_keys, or sign_update

Testing

I tested and verified my change by using one or multiple of these methods:

  • Sparkle Test App
  • Unit Tests
  • My own app
  • Other (please specify)

Verified Sparkle distribution tarball is still uploaded on Github actions page from this CI run.

macOS version tested: NA

The release workflow on GitHub uploads files that match "Sparkle-*" which apparently now includes sparkle-dist.tar.xz even though it's not capitalized. Rename the file to sparkle_dist to work around this.
@zorgiepoo zorgiepoo added this to the 2.7 milestone Dec 27, 2024
@zorgiepoo zorgiepoo merged commit 587aa02 into 2.x Dec 27, 2024
2 checks passed
@zorgiepoo zorgiepoo deleted the sparkle-dist-rename branch December 27, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant