Revive test_busy_handler_outwait and synchronize threads to remove "sleep 1". #459
+83
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masamitsu-murase
changed the title
|
Speeding up the test suite is a nice feature. I've been running the whole suite locally a lot lately, and these tests are very noticeable. |
flavorjones
force-pushed
the
improve_test_for_multithread
branch
from
d403335 to
ce532d5
Compare
|
I've rebased this onto current |
flavorjones
force-pushed
the
improve_test_for_multithread
branch
from
ce532d5 to
6899ba3
Compare
|
MacOS failures are unrelated, merging. @masamitsu-murase Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I revived
test_busy_handler_outwaitbecause I think that this test covers a good use case regardingbusy_handler.Ruby 1.9 and later does not allow a thread to unlock a
Mutexlocked by another thread, so I usedQueueto synchronize the main thread and another thread.I also refined other test methods to remove
sleep 1, which was used to synchronize threads.I hope this pull request improves this project, but please feel free to ignore it if it is not so useful.
Regards,
Murase