Ensure the Database#encoding method works when results are "as hash"
#481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a regression test for Rails. Rails instantiates SQLite3 with `results_as_hash` set to `true` by default. I broke the encoding method when that value is set to true, so this patch fixes it.
tenderlove
force-pushed
the
encoding-when-results-are-hash
branch
from
e0bcae8 to
271addd
Compare
|
@tenderlove thanks -- I should be able to get to setting up downstream integration testing with rails this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a regression test for Rails. Rails instantiates SQLite3 with
results_as_hashset totrueby default. I broke the encoding method when that value is set to true, so this patch fixes it.