Allow to use any HTML Element as menu item #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code works with any HTML element, there's nothing that requires specifically
HTMLAnchorElement
(<a>
) excepte.currentTarget.href
which is already conditional. Thus the current limitation is only a typing issue introduced by unnecessarily specificref
type. We can make it a generic parameter, but it wouldn't bring any real benefit, just increase complexity and decrease flexibility.Resolves #174