Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for text-based toolbar options #446

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

mikeangstadt
Copy link

Added the ability to pass innerHTML text for toolbar icon anchors.

Added the ability to pass innerHTML text for toolbar icon anchors.
@WesCossick
Copy link
Member

Can you submit a JSFiddle that demonstrates this change? That way, it can be tested by myself and other contributors.

@mikeangstadt
Copy link
Author

I'm using it as a node dependency, so I don't have my code hosted anywhere to point at from a JSFiddle - BUT! Here is a configuration overriding the Preview button in the toolbar that you can use in testing it.

https://jsfiddle.net/vx1qjgvo/

@sparksuite-bot
Copy link
Collaborator

A JSFiddle for this pull request can be found here. If it doesn't inherently demonstrate the proposed change, please fork the fiddle and make the necessary modifications to demonstrate this pull request. Then comment the new URL to your forked fiddle.

@charleneChen
Copy link

A new demonstrated JSFiddle can be found here

https://jsfiddle.net/07f4ryhj/

@riccardoratta
Copy link

This feature is fundamental for use others icons packs like material icons! Indeed we have to write the InnerHTML proprieties to get the<a class="material-icons">face</a> button.

Please @WesCossick, can you merge the branch?

@guifeliper
Copy link

@WesCossick can you merge this branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants