Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first address label re-used when receiving to multiple addresses in the same transaction #1600

Open
AndySchroder opened this issue Jan 21, 2025 · 2 comments

Comments

@AndySchroder
Copy link

When I receive in a single transaction to two or more addresses in the same wallet, there is a single transaction that shows up and then I can click an arrow on the left to expand and see the individual UTXO for that transaction. Visually, this is a really good UI design, but I'm having some problems with the labels that are applied.

Before making the transaction, I've assigned a label to each receiving address. However, after making the transaction, the label for each UTXO matches the label that I assigned to the first address under "Addresses". Then when I go to "Addresses", I see that all the labels for those addresses have also been changed to match the label of the first address from that transaction.

The labels for each address should stay the same and the UTXO associated with each of those addresses should match the label that was originally assigned to their address.

I realize that in this scenario you need to pick something to name the transaction with. I think using the label of the first address makes sense, but once expanding, each UTXO should show the correct label that belongs to the address the UTXO goes with. If using the label of the first address as the label for the entire transaction is not what I want, I can always rename that manually, but.....

If I manually rename the transaction, it also does the same thing, it renames all UTXO and all addresses associated with that transaction. If I have different labels already defined for the different UTXO and addresses in a transaction, renaming the transaction should not rename them.

The current behavior makes sense for a transaction with a single UTXO belonging to my wallet and a single UTXO belonging to each address. I would like renaming a transaction to rename the UTXO and address if I only have a single UTXO associated with that address. However, if I have multiple UTXO associated with an address or multiple UTXO associated with a transaction, things should be more intelligent.

@craigraw
Copy link
Collaborator

If I have different labels already defined for the different UTXO and addresses in a transaction, renaming the transaction should not rename them.

This is how things already work. When propagating label edits, Sparrow only changes labels that match the label being edited - not ones that have been changed to something else.

That said I'm struggling to follow all this. It's really better to have a series of steps to indicate what you mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants
@craigraw @AndySchroder and others