feat: ics as file

[atymic]

Context and Purposes

Sometimes, we want to be able to download a file rather than embedding a base64 link.
I used the existing options but would be open to doing it a different way if prefered.

[MehGokalp]

I was looking for this solution. Thanks

[UksusoFF]

Similar PR was closed with no activity: #139

So let's make some noise :)

Can you merge it?

@alies-dev @freekmurze

[atymic]

@freekmurze
@alies-dev
Any updates on this one?

[alies-dev]

Hey
@atymic
@UksusoFF

Thank you a lot for your patience. I appreciate your help and passion to improve this package! 💪

A saw few PRs here, all of them tried to add more functionality to ICS generator by adding more options to the $options argument. There are a few types of problems:

• violation of package principles (see the main readme)
• trying to make ICS really big and complex. This package doesn't have a goal to be a comprehensive ICS generator, it's made to support basic ICS rules, also available in other generators. For advanced users, this package supports custom generators that you can use by calling with \Spatie\CalendarLinks\Link::formatWith()
• mixing ICS components with presentation logic

This particular PR has the issue # 3. Today I found a time to solve it and created another PR #185, can you please review it guys and leave your feedback? Will it solve your goals?

[alies-dev]

mixing ICS components and presentation logic, see #174 (comment) for details.

[UksusoFF]

@alies-dev
Yep, #185 is great.

[atymic]

I will close this PR in favour of #185