Merge pull request #11 from ankurk91/patch/geo

Fix issue with GEO property #10
spatie · Jan 7, 2020 · a91b6e5 · a91b6e5
2 parents 87a3bc4 + 35af65a
commit a91b6e5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/PropertyTypes/CoordinatesPropertyType.php b/src/PropertyTypes/CoordinatesPropertyType.php
@@ -32,7 +32,7 @@ public function __construct($names, float $lat, float $lng)
 
     public function getValue(): string
     {
-        return "{$this->lat},{$this->lng}";
+        return "{$this->lat};{$this->lng}";
     }
 
     public function getOriginalValue(): array

diff --git a/tests/Components/EventTest.php b/tests/Components/EventTest.php
@@ -130,7 +130,7 @@ public function it_can_generate_an_apple_structured_location()
 
         $property = $payload->getProperty('X-APPLE-STRUCTURED-LOCATION');
 
-        $this->assertEquals('51.2343,4.4287', $property->getValue());
+        $this->assertEquals('51.2343;4.4287', $property->getValue());
         $this->assertEquals([
             'lat' => 51.2343,
             'lng' => 4.4287,

diff --git a/tests/PropertyTypes/CoordinatesPropertyTypeTest.php b/tests/PropertyTypes/CoordinatesPropertyTypeTest.php
@@ -13,7 +13,7 @@ public function it_can_create_a_coordinates_property_type()
         $propertyType = new CoordinatesPropertyType('GEO', 10.5, 20.5);
 
         $this->assertEquals(['GEO'], $propertyType->getNames());
-        $this->assertEquals('10.5,20.5', $propertyType->getValue());
+        $this->assertEquals('10.5;20.5', $propertyType->getValue());
         $this->assertEquals([
             'lat' => 10.5,
             'lng' => 20.5,