Add enum support for flags #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase against |
…ags into enum-support # Conflicts: # src/Models/Concerns/HasFlags.php
|
Should be good now @freekmurze! |
|
Seems like the tests fail on L9. Could you take a look at that? I would be ok with bumping the minimum version to L10. |
|
Looks like it's just from php 8.0 being in the matrix. I've removed that, assuming that's the direction that it's headed. |
|
Seems good! Thank you for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be somewhat controversial.
I love the ability to use enums directly when checking things, such as the recent ability to use enums for
authorize(). This adds a similar capability to flagging/unflagging/checking flags on models.The caveat is that
BackedEnumwas introduced in PHP 8.1, which would theoretically be a breaking change here. While it would be ideal to useIlluminate\Support\enum_value, it's marked as@internalfor reasons not immediately clear.Thanks for your consideration!