Merge pull request #58 from pascalbaljet/performance

Performance update: using 'whereColumn' instead of 'groupBy' in the Query Scopes
spatie · Jun 11, 2019 · 11e79bd · 11e79bd
2 parents 34c67ea + 9ed02c8
commit 11e79bd
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/HasStatuses.php b/src/HasStatuses.php
@@ -72,7 +72,7 @@ function (QueryBuilder $query) {
                                     ->select(DB::raw('max(id)'))
                                     ->from($this->getStatusTableName())
                                     ->where('model_type', $this->getStatusModelType())
-                                    ->groupBy($this->getModelKeyColumnName());
+                                    ->whereColumn($this->getModelKeyColumnName(), $this->getQualifiedKeyName());
                             }
                         );
                 }
@@ -100,7 +100,7 @@ function (QueryBuilder $query) use ($names) {
                                     ->select(DB::raw('max(id)'))
                                     ->from($this->getStatusTableName())
                                     ->where('model_type', $this->getStatusModelType())
-                                    ->groupBy($this->getModelKeyColumnName());
+                                    ->whereColumn($this->getModelKeyColumnName(), $this->getQualifiedKeyName());
                             }
                         );
                 }