Merge pull request #124 from alfreddagenais/optimize-currentStatus-query

CHG: Optimize `scopeCurrentStatus` and `scopeOtherCurrentStatus` Query
spatie · May 2, 2024 · c8b8bd3 · c8b8bd3
2 parents b29e65d + 6ef92a6
commit c8b8bd3
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/src/HasStatuses.php b/src/HasStatuses.php
@@ -84,9 +84,9 @@ function (Builder $query) use ($names) {
                         ->whereIn('name', $names)
                         ->whereIn(
                             'id',
-                            function (QueryBuilder $query) {
-                                $query
-                                    ->select(DB::raw('max(id)'))
+                            function (QueryBuilder $subQuery) {
+                                $subQuery
+                                    ->selectRaw('max(id)')
                                     ->from($this->getStatusTableName())
                                     ->where('model_type', $this->getStatusModelType())
                                     ->whereColumn($this->getModelKeyColumnName(), $this->getQualifiedKeyName());
@@ -112,9 +112,9 @@ function (Builder $query) use ($names) {
                         ->whereNotIn('name', $names)
                         ->whereIn(
                             'id',
-                            function (QueryBuilder $query) use ($names) {
-                                $query
-                                    ->select(DB::raw('max(id)'))
+                            function (QueryBuilder $subQuery) {
+                                $subQuery
+                                    ->selectRaw('max(id)')
                                     ->from($this->getStatusTableName())
                                     ->where('model_type', $this->getStatusModelType())
                                     ->whereColumn($this->getModelKeyColumnName(), $this->getQualifiedKeyName());