feat: Add method to check if a model has never had a specific status #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `hasNeverHadStatus($name): bool` method to determine if the model has never had a status with the given name. - Included PHPDoc comments for both `hasEverHadStatus($name): bool` and `hasNeverHadStatus($name): bool` methods. - Added tests for `hasNeverHadStatus` method: - Test to return `false` if the specific status is found. - Test to return `true` if the specific status is not found. This contribution introduces the inverse of the `hasEverHadStatus` function and improves documentation.
freekmurze
requested changes
May 24, 2024
- Updated `hasNeverHadStatus($name): bool` method to return the negation of `hasEverHadStatus($name)`, simplifying the logic. This change was made following a review suggestion from @freekmurze to avoid redundant logic.
|
Could you also add an example to the readme? |
|
Sure, done |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasNeverHadStatus($name): boolmethod to determine if the model has never had a status with the given name.hasEverHadStatus($name): boolandhasNeverHadStatus($name): boolmethods.hasNeverHadStatusmethod:falseif the specific status is found.trueif the specific status is not found.This contribution introduces the inverse of the
hasEverHadStatusfunction and improves documentation.