Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I was checking out this package on my machine and came across an issue -- I noticed that the
format
script added tocomposer.json
wouldn't run. There were two issues:friendsofphp/php-cs-fixer
development dependency, so there was an expectation that it would be installed globallyChanges
Add dependency
I added the current version of the dependency:
Update Composer script
The script was defined like this:
But since it needs a path, it's now changed to:
Run php-cs-fixer
Finally, I ran
composer format
and let it run through the project.Results
The changes are minimal, and all tests are passing. I ran a test without
--allow-risky=yes
and no additional files are changed, so it might be a good idea to remove this, but again I didn't want to assume why it might be there so I kept this initial pass a straightforward one.