Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added support for passing locale on multiple HasTags methods #488

Closed
wants to merge 5 commits into from

Conversation

Velka-DEV
Copy link

No description provided.

@freekmurze
Copy link
Member

Could you add tests and update the readme?

@Velka-DEV
Copy link
Author

Could you add tests and update the readme?

I've updated the README with the necessary examples. However, I'm seeking clarification on the types of tests you're expecting. Since this update doesn't introduce new features and mainly involves passing locale to a nested method, I'm unsure about the specific tests needed. Could you provide some guidance on this?

@freekmurze
Copy link
Member

The test should execute a method like NewsItem::withAnyTags(['first tag', 'second tag'], locale: 'en')->get(); and verify if you get the results you expect.

@freekmurze freekmurze closed this Dec 7, 2023
@freekmurze freekmurze reopened this Dec 7, 2023
@Velka-DEV
Copy link
Author

The test should execute a method like NewsItem::withAnyTags(['first tag', 'second tag'], locale: 'en')->get(); and verify if you get the results you expect.

Apologies for the late response, I missed the notification. I've now added tests for the updated methods.

@spatie-bot
Copy link

Dear contributor,

because this pull request seems to be inactive for quite some time now, I've automatically closed it. If you feel this pull request deserves some attention from my human colleagues feel free to reopen it.

@spatie-bot spatie-bot closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants