Attributes can be specified like #[\Foo()], not just like Foo

src/DisallowedAttributeFactory.php

@@ -37,11 +37,11 @@ public function createFromConfig(array $config): array
 			$attributes = $disallowed['attribute'];
 			$excludes = [];
 			foreach ((array)($disallowed['exclude'] ?? []) as $exclude) {
-				$excludes[] = $this->normalizer->normalizeNamespace($exclude);
+				$excludes[] = $this->normalizer->normalizeAttribute($exclude);
 			}
 			foreach ((array)$attributes as $attribute) {
 				$disallowedAttribute = new DisallowedAttribute(
-					$this->normalizer->normalizeNamespace($attribute),
+					$this->normalizer->normalizeAttribute($attribute),
 					$excludes,
 					$disallowed['message'] ?? null,
 					$this->allowed->getConfig($disallowed),

src/Normalizer/Normalizer.php

@@ -8,7 +8,7 @@ class Normalizer
 
 	public function normalizeCall(string $call): string
 	{
-		$call = substr($call, -2) === '()' ? substr($call, 0, -2) : $call;
+		$call = $this->removeParentheses($call);
 		return $this->normalizeNamespace($call);
 	}
 
@@ -18,4 +18,19 @@ public function normalizeNamespace(string $namespace): string
 		return ltrim($namespace, '\\');
 	}
 
+
+	public function normalizeAttribute(string $attribute): string
+	{
+		$attribute = ltrim($attribute, '#[');
+		$attribute = rtrim($attribute, ']');
+		$attribute = $this->removeParentheses($attribute);
+		return $this->normalizeNamespace($attribute);
+	}
+
+
+	private function removeParentheses(string $element): string
+	{
+		return substr($element, -2) === '()' ? substr($element, 0, -2) : $element;
+	}
+
 }

tests/Normalizer/NormalizerTest.php

@@ -33,4 +33,15 @@ public function testNormalizeNamespace(): void
 		$this->assertSame('foo\\bar', $this->normalizer->normalizeNamespace('\\foo\\bar'));
 	}
 
+
+	public function testNormalizeAttribute(): void
+	{
+		$this->assertSame('foo', $this->normalizer->normalizeAttribute('foo'));
+		$this->assertSame('foo', $this->normalizer->normalizeAttribute('foo()'));
+		$this->assertSame('foo', $this->normalizer->normalizeAttribute('\\foo()'));
+		$this->assertSame('foo', $this->normalizer->normalizeAttribute('#[\\foo]'));
+		$this->assertSame('foo', $this->normalizer->normalizeAttribute('#[\\foo()]'));
+		$this->assertSame('foo\\bar', $this->normalizer->normalizeAttribute('#[\\foo\\bar()]'));
+	}
+
 }

tests/Usages/AttributeUsagesAllowParamsMultipleTest.php

@@ -49,6 +49,12 @@ protected function getRule(): Rule
 						],
 					],
 				],
+				[
+					'attribute' => '#[\Attributes\AttributeClass()]',
+					'allowIn' => [
+						'../src/disallowed-allow/ClassWithAttributesAllow.php',
+					],
+				],
 			]
 		);
 	}
@@ -64,6 +70,10 @@ public function testRule(): void
 				// on this line:
 				8,
 			],
+			[
+				'Attribute Attributes\AttributeClass is forbidden, because reasons',
+				30,
+			],
 		]);
 		$this->analyse([__DIR__ . '/../src/disallowed-allow/ClassWithAttributesAllow.php'], [
 			[

tests/Usages/AttributeUsagesTest.php

@@ -41,6 +41,12 @@ protected function getRule(): Rule
 						],
 					],
 				],
+				[
+					'attribute' => '#[\Attributes\AttributeClass()]',
+					'allowIn' => [
+						'../src/disallowed-allow/ClassWithAttributesAllow.php',
+					],
+				],
 			]
 		);
 	}
@@ -56,6 +62,10 @@ public function testRule(): void
 				// on this line:
 				8,
 			],
+			[
+				'Attribute Attributes\AttributeClass is forbidden, because reasons',
+				30,
+			],
 		]);
 		$this->analyse([__DIR__ . '/../src/disallowed-allow/ClassWithAttributesAllow.php'], []);
 	}

tests/libs/AttributeClass.php

@@ -0,0 +1,11 @@
+<?php
+declare(strict_types = 1);
+
+namespace Attributes;
+
+use Attribute;
+
+#[Attribute]
+class AttributeClass
+{
+}

tests/src/disallowed-allow/ClassWithAttributesAllow.php

@@ -26,4 +26,10 @@ public function hasKetchup(): bool
 	{
 	}
 
+
+	#[AttributeClass()] // allowed by path in all tests
+	public function hasPineapple(): bool
+	{
+	}
+
 }

tests/src/disallowed/ClassWithAttributes.php

@@ -26,4 +26,10 @@ public function hasKetchup(): bool
 	{
 	}
 
+
+	#[AttributeClass()] // disallowed
+	public function hasPineapple(): bool
+	{
+	}
+
 }