-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added state-transition table representation and support for CFG #13
Conversation
src/main/kotlin/automaton/constructor/view/AutomatonTransitionTableView.kt
Outdated
Show resolved
Hide resolved
tab("Graph representation") { | ||
add(graphTab) | ||
} | ||
tab("State-transition table representation") { | ||
add(tableTab) | ||
} | ||
tab("Adjacency matrix representation") { | ||
add(matrixTab) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Задача #18
src/main/kotlin/automaton/constructor/model/automaton/PushdownAutomaton.kt
Show resolved
Hide resolved
src/main/kotlin/automaton/constructor/view/algorithms/ConversionToCFGView.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/automaton/constructor/view/AutomatonTransitionTableView.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/automaton/constructor/view/AutomatonAdjacencyMatrixView.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/automaton/constructor/view/AutomatonTableView.kt
Outdated
Show resolved
Hide resolved
val transitions: MutableMap<K, SimpleObjectProperty<List<Transition>>> = mutableMapOf() | ||
) | ||
|
||
class SourceCell<T: TableTransitionView, K>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Циклические зависимости между классами AutomatonTableView
, SourceCell
, TransitionsCell
. Затрудняют понимание кода. Рекомендую выделить интерфейс из класса AutomatonTableView
, чтобы SourceCell
и TransitionsCell
зависли нет от самого AutomatonTableView
, а от небольшого интерфейса.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: #23
src/main/kotlin/automaton/constructor/controller/algorithms/HellingsAlgoController.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/automaton/constructor/view/algorithms/HellingsAlgoInputView.kt
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,12 @@ | |||
package automaton.constructor.view |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Слишком много классов в этом пакете, надо разбить на подпакеты
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue: #23
src/main/kotlin/automaton/constructor/controller/AlgorithmsController.kt
Show resolved
Hide resolved
src/test/kotlin/automaton/constructor/model/algorithms/HellingsAlgoTests.kt
Outdated
Show resolved
Hide resolved
…e representations" This reverts commit 1056d05.
…/spbu-se/KotlinAutomataConstructor into automatonRepresentationsAndAlgos
…its possible to delete productions from Hellings grammar
Давай, как и договаривались, смерджим и, если еще есть, оставшиеся проблемы записывать в Issues |
Хорошо, тогда жду, когда заведёшь задачи для актуальных комментариев и других известных тебе проблем, например, неактуального состояния README и Wiki. Шаблоны issue я сделал и для первого незакрытого комментария задачу уже завёл. |
No description provided.