Fix some underlying issues with tensor core sample #1336
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After messing with the tensor core example some, myself and @tbennun noticed some issues with the sample. This PR fixes a few issues.
Accumulator
,TensorCore_*
) have been added todefined_vars
. In some cases not demonstrated inhgemm
, the codegen generates improper passes to functions. By setting the type toDefinedType.Stream
, we ensure that the WMMA fragments are always passed as an object reference.@replaces
to simpledace.tasklet
s. As with 1, certain situations not exposed withhgemm
showed that memlets are not always properly generated with thefrag_fill
andwmma
functions. Changing their implementation todace.tasklet
ensures that memlets are now properly generated in all use cases, along with simplifying their implementation to a large degree.