Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some underlying issues with tensor core sample #1336

Merged
merged 4 commits into from
Jul 29, 2023
Merged

Fix some underlying issues with tensor core sample #1336

merged 4 commits into from
Jul 29, 2023

Conversation

computablee
Copy link
Contributor

After messing with the tensor core example some, myself and @tbennun noticed some issues with the sample. This PR fixes a few issues.

  1. The storage types (e.g., Accumulator, TensorCore_*) have been added to defined_vars. In some cases not demonstrated in hgemm, the codegen generates improper passes to functions. By setting the type to DefinedType.Stream, we ensure that the WMMA fragments are always passed as an object reference.
  2. The frontend is greatly redone and simplified, changing the use of @replaces to simple dace.tasklets. As with 1, certain situations not exposed with hgemm showed that memlets are not always properly generated with the frag_fill and wmma functions. Changing their implementation to dace.tasklet ensures that memlets are now properly generated in all use cases, along with simplifying their implementation to a large degree.

@computablee computablee marked this pull request as ready for review July 27, 2023 17:22
@tbennun tbennun self-requested a review July 29, 2023 21:07
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would recommend to change the name Stream in DefinedTypes to Object or something that would make more sense.

@tbennun tbennun merged commit 60b4045 into spcl:master Jul 29, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants