Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists.txt Improvements for CUDA #1337

Merged
merged 8 commits into from
Jan 1, 2024

Commits on Jul 28, 2023

  1. Updated deprecated FindCUDA to FindCUDAToolKit

    - Bumped cmake minimim version to 3.17
    - Changed `DACE_LIBS` element to `CUDA::cudart`
    - Removed unneeded `include_directories` and link_directories calls
    - Removed `compile_cuda`. CUDA files are now passed directly to targets
    - Removed `-fPIC` and `-std` args from nvcc as they are handled
      automatically now
    - Renamed `CUDA_NVCC_FLAGS` to `CMAKE_CUDA_FLAGS`
    kylosus committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    dd0b2a5 View commit details
    Browse the repository at this point in the history
  2. Reworked CUDA default architecture logic

    - Moved `-gencode` handling to `cmake`: cmake variable
      `DACE_CUDA_ARCHITECTURES_DEFAULT` is set in python code to be used by
      `CMAKE_CUDA_ARCHITECTURES` instead of manually creating the compiler arg string.
    - Default cuda arch is no longer included forcefully in presence of a native architecture
    - `get_cuda_arch.cpp` now returns a properly formatted architecture
      string compatible with cmake.
    - `get_cuda_arch.cpp` now fails if no architectures are found
    kylosus committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    c233f6a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e057856 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    abdfc88 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Fixed MPI target

    kylosus committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    02f0c76 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Reverting for portability issues

    This reverts commit abdfc88.
    kylosus committed Aug 1, 2023
    Configuration menu
    Copy the full SHA
    9b3946a View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Configuration menu
    Copy the full SHA
    1347655 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. Configuration menu
    Copy the full SHA
    de4ef6f View commit details
    Browse the repository at this point in the history