-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMakeLists.txt Improvements for CUDA #1337
Merged
Merged
Commits on Jul 28, 2023
-
Updated deprecated FindCUDA to FindCUDAToolKit
- Bumped cmake minimim version to 3.17 - Changed `DACE_LIBS` element to `CUDA::cudart` - Removed unneeded `include_directories` and link_directories calls - Removed `compile_cuda`. CUDA files are now passed directly to targets - Removed `-fPIC` and `-std` args from nvcc as they are handled automatically now - Renamed `CUDA_NVCC_FLAGS` to `CMAKE_CUDA_FLAGS`
Configuration menu - View commit details
-
Copy full SHA for dd0b2a5 - Browse repository at this point
Copy the full SHA dd0b2a5View commit details -
Reworked CUDA default architecture logic
- Moved `-gencode` handling to `cmake`: cmake variable `DACE_CUDA_ARCHITECTURES_DEFAULT` is set in python code to be used by `CMAKE_CUDA_ARCHITECTURES` instead of manually creating the compiler arg string. - Default cuda arch is no longer included forcefully in presence of a native architecture - `get_cuda_arch.cpp` now returns a properly formatted architecture string compatible with cmake. - `get_cuda_arch.cpp` now fails if no architectures are found
Configuration menu - View commit details
-
Copy full SHA for c233f6a - Browse repository at this point
Copy the full SHA c233f6aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e057856 - Browse repository at this point
Copy the full SHA e057856View commit details -
Configuration menu - View commit details
-
Copy full SHA for abdfc88 - Browse repository at this point
Copy the full SHA abdfc88View commit details
Commits on Jul 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 02f0c76 - Browse repository at this point
Copy the full SHA 02f0c76View commit details
Commits on Aug 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 9b3946a - Browse repository at this point
Copy the full SHA 9b3946aView commit details
Commits on Nov 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 1347655 - Browse repository at this point
Copy the full SHA 1347655View commit details
Commits on Dec 1, 2023
-
Configuration menu - View commit details
-
Copy full SHA for de4ef6f - Browse repository at this point
Copy the full SHA de4ef6fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.