Various Cutout Fixes #1662
Merged
Various Cutout Fixes #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
phschaad
commented
Sep 19, 2024
•
phschaad
commented
- Fix cutouts w.r.t. the use of UIDs, allowing them to be preserved or re-generated depending on an input parameter
- Fix singlestate cutout extraction when memlets access struct members.
tbennun
requested changes
Oct 31, 2024
dace/sdfg/analysis/cutout.py
Outdated
| :param override_start_block: If set, explicitly force a given control flow block to be the start block. If left | ||
| None (default), the start block is automatically determined based on domination | ||
| relationships in the original graph. | ||
| :return: The created SDFGCutout or the original SDFG where no smaller cutout could be obtained. | ||
| """ | ||
| create_element = copy.deepcopy | ||
| def create_element(x: Union[ControlFlowBlock, InterstateEdge]) -> Union[ControlFlowBlock, InterstateEdge]: | ||
| return x.clone(keep_guid=preserve_guids) |
There was a problem hiding this comment.
I would use an inline lambda, it's much cleaner
There was a problem hiding this comment.
After removing the clone function I believe it is cleaner this way since this way provides type information, while lambdas completely remove the ability to type hint things (cleanly)
tbennun
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.