Cherry-picked a handful of intrinsic related commits out of multi_sdfg branch.
#1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratyai
changed the title
multi_sdfg branch that are 1) chrnologically first, 2) fairly indepdent and touches a small amount of files, and 3) thematically fit together.multi_sdfg branch that are 1) chrnologically early, 2) fairly indepdent and touches a small amount of files, and 3) thematically fit together.
pratyai
changed the title
multi_sdfg branch that are 1) chrnologically early, 2) fairly indepdent and touches a small amount of files, and 3) thematically fit together.multi_sdfg branch that are 1) chrnologically early, 2) fairly indepdent and touches a small number of files, and 3) thematically fit together.
pratyai
changed the title
multi_sdfg branch that are 1) chrnologically early, 2) fairly indepdent and touches a small number of files, and 3) thematically fit together.multi_sdfg branch that 1) are chrnologically early, 2) fairly indepdent and touch a small number of files, and 3) thematically fit together.
pratyai
changed the title
multi_sdfg branch that 1) are chrnologically early, 2) fairly indepdent and touch a small number of files, and 3) thematically fit together.multi_sdfg branch that 1) are chrnologically early, 2) fairly independent and touch a small number of files, and 3) thematically fit together.
pratyai
changed the title
multi_sdfg branch that 1) are chrnologically early, 2) fairly independent and touch a small number of files, and 3) thematically fit together.multi_sdfg branch.
pratyai
force-pushed
the
intrinsic_math
branch
from
5d22609
to
4cf4ebf
Compare
Previously, we didn't extract function calls that appear in function arguments. Now we can support that. To that end, we have to declare extracted calls in reverse order - first process arguments, then the main call.
fortran program that passes under `gfortran -Wall`.
|
@pratyai One more issue: some of the test files might have commented out test function calls; it should be a leftover of prior work. Can you please verify that tests still run after enabling them again? |
mcopik
requested changes
Nov 5, 2024
pratyai
force-pushed
the
intrinsic_math
branch
from
8e05082
to
3488c58
Compare
Done. |
mcopik
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits:
This is a follow-up on the discussion about incrementally moving the stable features from
multi_sdfgbranch intomain. All of the commits are cherry-picked to preserve the history and to have easy fast-forwarding of themulti_sdfgbranch.Some commits had to be slightly modified to resolve the merge conflicts during cherry-picking, but otherwise they are left as-is.