Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Node.add_{in, out}_connector(). #1828

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Updated Node.add_{in, out}_connector(). #1828

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e85d444
Performance improvement in the `add_{in, out}_connector()` functions …
philip-paul-mueller Dec 13, 2024
a7204a3
Merge branch 'main' into Improved_connector_management
philip-paul-mueller Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions dace/sdfg/nodes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,40 +108,40 @@ def to_json(self, parent):
def __repr__(self):
return type(self).__name__ + ' (' + self.__str__() + ')'

def add_in_connector(self, connector_name: str, dtype: dtypes.typeclass = None, force: bool = False):
def add_in_connector(self, connector_name: str, dtype: Any = None, force: bool = False):
""" Adds a new input connector to the node. The operation will fail if
a connector (either input or output) with the same name already
exists in the node.

:param connector_name: The name of the new connector.
:param dtype: The type of the connector, or None for auto-detect.
:param force: Add connector even if output connector already exists.
:param force: Add connector even if input or output connector of that name already exists.
:return: True if the operation is successful, otherwise False.
"""

if (not force and (connector_name in self.in_connectors or connector_name in self.out_connectors)):
return False
connectors = self.in_connectors
connectors[connector_name] = dtype
self.in_connectors = connectors
if not isinstance(dtype, dace.typeclass):
dtype = dace.typeclass(dtype)
self.in_connectors[connector_name] = dtype
return True

def add_out_connector(self, connector_name: str, dtype: dtypes.typeclass = None, force: bool = False):
def add_out_connector(self, connector_name: str, dtype: Any = None, force: bool = False,) -> bool:
""" Adds a new output connector to the node. The operation will fail if
a connector (either input or output) with the same name already
exists in the node.

:param connector_name: The name of the new connector.
:param dtype: The type of the connector, or None for auto-detect.
:param force: Add connector even if input connector already exists.
:param force: Add connector even if input or output connector of that name already exists.
:return: True if the operation is successful, otherwise False.
"""

if (not force and (connector_name in self.in_connectors or connector_name in self.out_connectors)):
return False
connectors = self.out_connectors
connectors[connector_name] = dtype
self.out_connectors = connectors
if not isinstance(dtype, dace.typeclass):
dtype = dace.typeclass(dtype)
self.out_connectors[connector_name] = dtype
return True

def remove_in_connector(self, connector_name: str):
Expand Down
Loading