Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[f2dace/dev, fortran] Now that we don't look up files from module names, and as such don't have the no-more-than-one-module-per-file rule, we can relax the test helper and also not pass a main in ParseConfig. #1916

Open
wants to merge 7 commits into
base: f2dace/dev
Choose a base branch
from

Conversation

pratyai
Copy link
Collaborator

@pratyai pratyai commented Jan 31, 2025

Benefit:
In tests, now we can just add_file() once with the whole test code with all the modules and programs. Before, we had to add_file() each module separately, because recursive_ast_improver() looked up files by module names, which didn't work if a file contained multiple modules. Now that we've replaced that function that does not assume anything about file names, we can add everything in one file, and it's valid (as long as it's a valid Fortran program).
That in turn makes it easier to copy the test code in a file, verify if it compiles, edit it until it does, then copy it back.

argument from `ParseConfig` constructor on some callsites.
have the no-more-than-one-module-per-file rule, we can relax the test
helper and also not pass a `main` in `ParseConfig`.
@pratyai pratyai marked this pull request as ready for review January 31, 2025 11:17
@pratyai
Copy link
Collaborator Author

pratyai commented Jan 31, 2025

Screenshot 2025-01-31 at 14 37 40

The usual 9.

@pratyai pratyai requested a review from acalotoiu January 31, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant