issue #20 CLI operations improved #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcopik
requested changes
Apr 21, 2023
| @@ -137,70 +137,33 @@ def process_cmd(client: FaaSKeeperClient, cmd: str, args: List[str]): | |||
| return client.session_status, client.session_id | |||
|
|
|||
|
|
|||
| @click.command() | |||
There was a problem hiding this comment.
Why all of this code has been removed? The purpose is to extend the existing implementation, not completely replace it.
|
@shailendrasingh117 I'm confused - the code in the PR replaces the existing implementation, does not implement any handling of arguments, and it's very different from what has been posted in issue #20. Furthermore, you mentioned fixing a bug for socket closure - this one is also missing. |
|
This PR will be closed due to a lack of responses to the code review and no activity. If you want to continue working on this issue, please feel free to push changes and reopen it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20 So the main issue was:
The writer function has been extended to include options for ephemeral and sequential nodes.
The updated code now includes error handling for handling the case when the socket is closed by the write function.
Issues Resolved.