Create history-OSI-SPDX (2nd try) #2504
Conversation
|
The file does not have .md extension therefore is GitHub will not format it as Markdow. Can you please add the suffix to the filename, please? |
|
Otherwise technically LGTM. |
add file extension
where is the facepalm emoji when you need it?!? :) |
There was a problem hiding this comment.
Hi @jlovejoy, I've gone through and added a few specific questions / edits to consider below.
For the overall history part at the beginning, I think this makes a lot of sense to capture as a historical record for development of the early license list and interactions with OSI.
For the particular issues described further down, I'm assuming that these are meant more as a temporary gathering-together of related issues? In the long run, I'm guessing that these would ideally end up either addressed by OSI where needed, perhaps via issues in https://github.com/OpenSourceOrg/licenses (I know you've captured some of these below). Or, perhaps more appropriate to include comments in the "Notes" fields for applicable license IDs on the SPDX License List, since otherwise I'm guessing ordinary users won't know to look here for them. Either way, as an initial place to store these details, I think this works.
|
@swinslow - addressed your suggestions, want to have a quick look and then merge? |
|
Thank you |
made this as new PR b/c #1738 was failing tests. See #1738 for background if need be.
Signed-off-by: Jilayne Lovejoy