Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensing: Move up note on declared vs concluded license disagreement #787

Merged
merged 7 commits into from
Jul 23, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Jun 14, 2024

  • Currently the note about what to do when there is a disagreement between hasDeclaredLicense and hasConcludedLicense is buried down the bottom of the page
  • It is also not very noticeable due to the fact that it has no proper heading, make it looks like it is under the "hasConcludedLicense" section. Which in fact, it is not. The last two paragraphs are meant to be at the "root" level of the description.
  • This PR move up the note to the position next to the paragraph that introduces hasDeclaredLicense and hasConcludedLicense concepts.

@goneall
Copy link
Member

goneall commented Jul 22, 2024

@swinslow @zvr - Can you do a quick review - if OK, we'd like to merge

@goneall goneall added this to the 3.0.1 milestone Jul 22, 2024
@goneall
Copy link
Member

goneall commented Jul 22, 2024

@bact - could you update to resolve the merge conflicts?

@swinslow - Please take a look - if you agree, we can merge.

@bact
Copy link
Collaborator Author

bact commented Jul 22, 2024

@goneall Conflict resolved.

Copy link
Member

@swinslow swinslow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- I did notice one typo (not from your PR) -- if you want to fix that now as well, great! Otherwise looks good to go as-is.

Signed-off-by: Arthit Suriyawongkul <[email protected]>
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo fixed - LGTM

@goneall goneall merged commit fcb3829 into spdx:main Jul 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants