Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "low" entry of CvssSeverityType #793

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

bact
Copy link
Collaborator

@bact bact commented Jun 29, 2024

"low" entry should be for 0.1-3.9 range of CVSS score, not 0-3.9.

Current:

- critical: When a CVSS score is between 9.0 - 10.0
- high: When a CVSS score is between 7.0 - 8.9
- medium: When a CVSS score is between 4 - 6.9
- low: When a CVSS score is between 0 - 3.9
- none: When a CVSS score is 0

Proposed fix:

- critical: When a CVSS score is between 9.0 - 10.0
- high: When a CVSS score is between 7.0 - 8.9
- medium: When a CVSS score is between 4.0 - 6.9
- low: When a CVSS score is between 0.1 - 3.9
- none: When a CVSS score is 0.0

Refs:
Qualitative Severity Rating Scale

@bact
Copy link
Collaborator Author

bact commented Jul 16, 2024

Discussed in 2024-07-16 Tech team meeting, PR needs to remove the re-formatting otherwise looks good.

Formatting removed. Ready for re-review @rnjudge. Thank you.

@goneall goneall added this to the 3.0.1 milestone Jul 22, 2024
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - All the updates have been made per comments

@goneall goneall merged commit 435b486 into spdx:main Jul 22, 2024
1 check passed
@bact bact deleted the fix-CvssSeverityType-entry branch July 22, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants