Fix types in Security example snippets #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `xsd:demical` value should be inside a quote - `CvssSeverityType` entry value should be in lower case Signed-off-by: Arthit Suriyawongkul <[email protected]>
- Add `security_` prefix for security properties - `@id` -> `spdxId` - `@type` -> `type` - `externalRefs` -> `externalRef` - `externalIdentifiers` -> `externalIdentifier` - `"externalIdentifierType": "securityAdvisory"` -> `"externalIdentifierType": "securityOther"` (there is no `securityAdvisory` entry in `ExternalIdentifierType` vocab) - CvssV4VulnAssessmentRelationship: change `to` value to array (cardinality ..*) Signed-off-by: Arthit Suriyawongkul <[email protected]>
goneall
approved these changes
Jul 22, 2024
kestewart
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revise example snippets ("Syntax" section) in *VulnAssessmentRelationship classes:
xsd:decimalvalue inside a quoteCvssSeverityTypeentry value to lower case, per https://spdx.github.io/spdx-spec/v3.0/model/Security/Vocabularies/CvssSeverityType/tovalue to array (cardinality ..*) (in CvssV4VulnAssessmentRelationship)externalRefs->externalRefexternalIdentifiers->externalIdentifier"externalIdentifierType": "securityAdvisory"->"externalIdentifierType": "securityOther"securityAdvisoryentry inExternalIdentifierTypevocab (It is inExternalRefTypevocab)security_prefix to security properties@id->spdxId@type->type