-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NamespaceMap: Remove TODO and fix caps #796
Conversation
bact
commented
Jul 2, 2024
•
edited
Loading
edited
- Remove "TODO" as the URLs are already updated. (although they are all pointing directly to the repo: https://github.com/spdx/spdx-3-model/ - is this something we are preferred?)
- Also use 4-space indent for list, to keep the multiple paragraphs rendered correctly.
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact I personally think we should point to the generated mkdocs HTML pages rather than the repo. We can discuss on the next tech call. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Also use 4-space indent for bullet list, to keep the multiple paragraphs rendered correctly. Signed-off-by: Arthit Suriyawongkul <[email protected]>
@goneall Our current "Model and serializations" page at https://spdx.github.io/spdx-spec/v3.0/serializations/ does not has information about NamespaceMap. While our "Notes on Serialization" at https://github.com/spdx/spdx-3-model/tree/main/serialization#readme has it. |
Discussed on 30 July 2024 tech call:
|
@kestewart @goneall A PR #1016 is open to add NamespaceMap info to the "Models and serializations" chapter of the spec. |
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Co-authored-by: Alexios Zavras (zvr) <[email protected]> Signed-off-by: Arthit Suriyawongkul <[email protected]>
Co-authored-by: Alexios Zavras (zvr) <[email protected]> Signed-off-by: Arthit Suriyawongkul <[email protected]>
@zvr @kestewart this PR was automatically and unintentionally closed by GitHub because the description of PR #1016 has the word "fix" before this PR number. Do you mind to reopen this please? Thank you. |
Reopened as #821, with a new fix |