Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NamespaceMap: Remove TODO and fix caps #796

Closed
wants to merge 8 commits into from

Conversation

bact
Copy link
Collaborator

@bact bact commented Jul 2, 2024

  • Remove "TODO" as the URLs are already updated. (although they are all pointing directly to the repo: https://github.com/spdx/spdx-3-model/ - is this something we are preferred?)
  • Also use 4-space indent for list, to keep the multiple paragraphs rendered correctly.

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@goneall
Copy link
Member

goneall commented Jul 22, 2024

@bact I personally think we should point to the generated mkdocs HTML pages rather than the repo. We can discuss on the next tech call.

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Also use 4-space indent for bullet list, to keep the multiple paragraphs rendered correctly.

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Copy link
Collaborator Author

bact commented Jul 26, 2024

@bact I personally think we should point to the generated mkdocs HTML pages rather than the repo. We can discuss on the next tech call.

@goneall Our current "Model and serializations" page at https://spdx.github.io/spdx-spec/v3.0/serializations/ does not has information about NamespaceMap. While our "Notes on Serialization" at https://github.com/spdx/spdx-3-model/tree/main/serialization#readme has it.

@goneall
Copy link
Member

goneall commented Jul 30, 2024

Discussed on 30 July 2024 tech call:

  • Agreed we should point to the HTML - required for ISO
  • We need to open a pull request to add the information to the spec serialization section, then change the links in this PR

@bact
Copy link
Collaborator Author

bact commented Jul 31, 2024

We need to open a pull request to add the information to the spec serialization section, then change the links in this PR

@kestewart @goneall A PR #1016 is open to add NamespaceMap info to the "Models and serializations" chapter of the spec.

model/Core/Classes/NamespaceMap.md Outdated Show resolved Hide resolved
model/Core/Classes/NamespaceMap.md Outdated Show resolved Hide resolved
bact and others added 2 commits August 7, 2024 16:49
Co-authored-by: Alexios Zavras (zvr) <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
Co-authored-by: Alexios Zavras (zvr) <[email protected]>
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Copy link
Collaborator Author

bact commented Aug 8, 2024

@zvr @kestewart this PR was automatically and unintentionally closed by GitHub because the description of PR #1016 has the word "fix" before this PR number.

Do you mind to reopen this please? Thank you.
This is probably one of the few last PRs for 3.0.1 model.

@bact
Copy link
Collaborator Author

bact commented Aug 9, 2024

Reopened as #821, with a new fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants