Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary restrictions #797

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Conversation

zvr
Copy link
Member

@zvr zvr commented Jul 10, 2024

Now that spec-parser processes and check external property restrictions, the following warnings were generated:

WARNING: In class /AI/AIPackage property /Core/Artifact/releaseTime has same maxCount as the parent class
WARNING: In class /AI/AIPackage property /Core/Artifact/suppliedBy has same maxCount as the parent class
WARNING: In class /AI/AIPackage property /Software/Package/downloadLocation has same maxCount as the parent class
WARNING: In class /AI/AIPackage property /Software/Package/packageVersion has same maxCount as the parent class
WARNING: In class /AI/AIPackage property /Software/SoftwareArtifact/primaryPurpose has same maxCount as the parent class
WARNING: In class /Dataset/DatasetPackage property /Core/Artifact/builtTime has same maxCount as the parent class
WARNING: In class /Dataset/DatasetPackage property /Core/Artifact/releaseTime has same maxCount as the parent class
WARNING: In class /Dataset/DatasetPackage property /Software/Package/downloadLocation has same maxCount as the parent class
WARNING: In class /Dataset/DatasetPackage property /Software/SoftwareArtifact/primaryPurpose has same maxCount as the parent class
WARNING: In class /Security/VulnAssessmentRelationship property /Core/Relationship/to has same minCount as the parent class

This PR removes these unnecessary external property restrictions.

@zvr zvr added this to the 3.0.1 milestone Jul 10, 2024
@kestewart
Copy link
Contributor

@rgopikrishnan91 - please review.

@bact
Copy link
Collaborator

bact commented Jul 16, 2024

Discussed in 2024-07-16 Tech team meeting, agree to merge.

Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - based on comments, was approved during tech call - merging

@goneall goneall merged commit 2f8066e into spdx:main Jul 22, 2024
1 check passed
@zvr zvr deleted the unnecessary-restrictions branch August 12, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants