Implement Class NodeKind support #107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPEWdev
added a commit
to JPEWdev/spdx-3-model
that referenced
this pull request
Mar 22, 2024
Sets the NodeKind for elements to be an IRI. This prevents them from being able to use blank nodes in the SHACL model. Requires spdx/spec-parser#107 Signed-off-by: Joshua Watt <[email protected]>
Since classes can specify constraints other than just properties, make them always be NodeShapes
Elements must have a fully qualified IRI; blank nodes are not allowed to add the NodeKind constraint to the class
|
@zvr will review |
|
I think this is not needed any more, as it's being taken care of. @JPEWdev can we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Classes to specify what kind of node they must be (e.g. "IRI", "BlankNode", "BlankNodeOrIRI")