feat: autocomplete works with tilde and absolute dirs #1216
+17
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows absolute paths to work in autocomplete.
For
~paths we are currently validating them out. There is actually no reason we can't provide file suggestions for~/paths, that's not difficult, the problem is actually downstream in the workflow file/sdk generation those file references will not be valid. One option would be to convert a~/path right after the form completes to a relative path. I'm not sure if that's better than just disallowing it though with clear messaging. Fishing for thoughts.I think the discussion of whether or not we even want to allow use of files outside your current directory in things like quickstart is a different discussion.
https://www.loom.com/share/a0d6bcfc6f0a417d8e727713d545c225?sid=5c07e75d-7781-4332-a88d-639a6e05d525
https://linear.app/speakeasy/issue/SPE-4581/bug-tab-completion-does-not-work-during-quickstart