Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swagger_spec_validator adds in x-scope property to definitions #214

Closed
wasbazi opened this issue Apr 21, 2016 · 0 comments
Closed

swagger_spec_validator adds in x-scope property to definitions #214

wasbazi opened this issue Apr 21, 2016 · 0 comments

Comments

@wasbazi
Copy link
Contributor

wasbazi commented Apr 21, 2016

When validating the swagger document the dictionary that is passed to swagger_spec_validator.validator20 is modified. It is possible for that library to add in any properties it wants to the spec.

Expected behavior, validation doesn't add in extra properties like x-scope to references.

Actual behavior, validation adds in extra properties like x-scope to references which can cause issues when using swagger clients that rely on the swagger_spec validator (like bravado). If the validator sets x-scope to the empty string then the bravado client can't properly understand where those references point to.

This was in a new connexion project, the swagger document had parameters defined as references.

Additional info:

Output of the commands:

  • python --version
    Python 3.5.1
  • pip show connexion | grep "^Version\:"
    Version: 1.0.89

This is related to this issue though allowing only a copy of the spec to be passed into the validator is a good idea on this side as well. Yelp/swagger_spec_validator#48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant