Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy spec before validation occurs #215

Merged
merged 2 commits into from
Apr 22, 2016

Conversation

wasbazi
Copy link
Contributor

@wasbazi wasbazi commented Apr 21, 2016

Fixes #214

Changes proposed in this pull request:

  • Copies the spec and passes the copy to validator instead of passing the original spec used later in the code

@jmcs
Copy link
Contributor

jmcs commented Apr 22, 2016

Thanks for the pull request. Please fix the failing unit test so we can merge the Pull Request.

@rafaelcaricio
Copy link
Collaborator

@wasbazi Sounds good, but you have to do:

self.specification = compatibility_layer(spec)

Because Connexion expects that the status codes to be integer value, probably that is why the tests are failing now.

@wasbazi
Copy link
Contributor Author

wasbazi commented Apr 22, 2016

Thanks for pointing out the issue with the tests, I hadn't noticed that at first and it's even easier to fix knowing what the problem is.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling bb7c68f on wasbazi:copy-before-validation into 44c5c5d on zalando:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6614d78 on wasbazi:copy-before-validation into eecca74 on zalando:master.

@rafaelcaricio
Copy link
Collaborator

👍

@rafaelcaricio rafaelcaricio merged commit dd206da into spec-first:master Apr 22, 2016
@wasbazi wasbazi deleted the copy-before-validation branch April 22, 2016 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants