-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support formatting of section headers above h6, correct computation of level #2772
base: main
Are you sure you want to change the base?
Conversation
Computation of nesting level assumed single digit / character section numbers. Headers deeper than h6 will be of form <h6 class="h7">
I'll add a test for this. Please review but don't merge yet. |
I'm a bit concerned about the accessibility implications of this. As per following page from WAI wiki, the recommended way of supporting heading level beyond h6 is: <div role="heading" aria-level="7">Jonagold/div> If it's fine to treat all headings above h6 as h6, I think this would be fine though. |
I understand the implications of deep nesting. I’m faced with an existing specification that I can’t change that uses h7.
I’ll fix the “bug” where I unnecessarily checked for an empty classList.
Steve Glaser
[email protected]
…On Feb 25, 2020, 1:21 AM -0800, Sid Vishnoi ***@***.***>, wrote:
I'm a bit concerned about the accessibility implications of this. As per following page from WAI wiki, the recommended way of supporting heading level beyond h6 is:
<div role="heading" aria-level="7">Jonagold/div>
Also see: https://stackoverflow.com/questions/55891025/is-h6-aria-level-7-a-reliable-way-to-create-a-h7-element
If it's fine to treat all headings above h6 as h6, I think this would be fine though.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
@stevefaulkner or @patrickhlauke, we could use your guidance here: if we want a "h7", should we do |
Headers above h6 will be of form <h6 class="h7"> so css can do magic.
The level computation assumed section numbers and appendix numbers were a single digit/character