-
-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core/webidl): add data-dfn-for to IDL sections #2893
base: main
Are you sure you want to change the base?
Conversation
src/core/webidl.js
Outdated
return; | ||
} else { | ||
closestSection.dataset.dfnFor = ""; | ||
const options = dfnFors.map(dfnFor => `"${dfnFor}"`).join(", "); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should not suggest these options? User might want to add something else?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, don't suggest these yet... remember that this currently works today:
<section data-dfn-for="Whatever">
<section>
<pre class="idl">
interface Whatever{};
interface SomethingElse{};
<pre>
</section>
</section>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, the above is probably bad practice and doesn't matter...
Part of https://github.com/w3c/respec/issues/1050