Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't dispose the blocking collection when cancelling #222

Merged
merged 5 commits into from
Feb 4, 2025

Conversation

adamhathcock
Copy link
Member

No description provided.

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.67%. Comparing base (7329155) to head (62c9f77).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...c/Speckle.Sdk/Api/Operations/Operations.Receive.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #222       +/-   ##
===========================================
+ Coverage   59.42%   70.67%   +11.25%     
===========================================
  Files         262      278       +16     
  Lines       10412    11135      +723     
  Branches     1103     1105        +2     
===========================================
+ Hits         6187     7870     +1683     
+ Misses       3963     2911     -1052     
- Partials      262      354       +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock changed the title don't dispose the blocking collection don't dispose the blocking collection when cancelling Feb 4, 2025
JR-Morgan
JR-Morgan previously approved these changes Feb 4, 2025
@JR-Morgan
Copy link
Member

Tested Rhino, Autocad, Civil

@adamhathcock adamhathcock merged commit b056d98 into dev Feb 4, 2025
4 checks passed
@adamhathcock adamhathcock deleted the no-dispose-bc branch February 4, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants