Add checks to clean XML reserved characters when used in page metadata #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moved the sed replacement into a separate PR. It's a good fix, but it turned out to not be the problem here, so it deserves to be its own PR. |
|
tested and it works!! |
neonspectra
force-pushed
the
1.1.0
branch
2 times, most recently
from
039c259 to
153ac6f
Compare
|
Time to merge in changes from upstream. Hopefully that doesn't break stuff after the disaster I inflicted on myself to fix my git blame... |
|
Added a fancy CI test to check and make sure we don't break this XML sanitisation down the line. Yay unit testing!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user might want to use XML reserved characters in their page metadata, not realising that this would break the sitemap or RSS feed. This PR implements a cleaner function to ensure such characters are automatically replaced with escape codes at runtime.
Edit:
This PR also adds a new unit test to make sure that the sanitisation actually works so that we don't break it down the line.