Merge pull request #1338 from nils-a/feature/GH-1188

spectreconsole · Oct 19, 2023 · 63b940c · 63b940c
2 parents e2a6748 + bbf58ee
commit 63b940c
Show file tree

Hide file tree

Showing 3 changed files with 30 additions and 2 deletions.
diff --git a/src/Spectre.Console/Widgets/Rows.cs b/src/Spectre.Console/Widgets/Rows.cs
@@ -41,8 +41,8 @@ protected override Measurement Measure(RenderOptions options, int maxWidth)
             if (measurements.Length > 0)
             {
                 return new Measurement(
-                    measurements.Min(c => c.Min),
-                    measurements.Min(c => c.Max));
+                    measurements.Max(c => c.Min),
+                    measurements.Max(c => c.Max));
             }
 
             return new Measurement(0, 0);

diff --git a/test/Spectre.Console.Tests/Expectations/Widgets/Rows/GH-1188-Rows.Output.verified.txt b/test/Spectre.Console.Tests/Expectations/Widgets/Rows/GH-1188-Rows.Output.verified.txt
@@ -0,0 +1,5 @@
+┌─────┐
+│ 1   │
+│ 22  │
+│ 333 │
+└─────┘
diff --git a/test/Spectre.Console.Tests/Unit/Widgets/RowsTests.cs b/test/Spectre.Console.Tests/Unit/Widgets/RowsTests.cs
@@ -4,6 +4,29 @@ namespace Spectre.Console.Tests.Unit;
 [ExpectationPath("Widgets/Rows")]
 public sealed class RowsTests
 {
+    [Fact]
+    [Expectation("GH-1188-Rows")]
+    [GitHubIssue("https://github.com/spectreconsole/spectre.console/issues/1188")]
+    public Task Should_Render_Rows_In_Panel_Without_Breaking_Lines()
+    {
+        // Given
+        var console = new TestConsole().Width(60);
+        var rows = new Rows(
+            new IRenderable[]
+            {
+                new Text("1"),
+                new Text("22"),
+                new Text("333"),
+            });
+        var panel = new Panel(rows);
+
+        // When
+        console.Write(panel);
+
+        // Then
+        return Verifier.Verify(console.Output);
+    }
+
     [Fact]
     [Expectation("Render")]
     public Task Should_Render_Rows()