Skip to content

Improvements to path handling #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Improvements to path handling #95

wants to merge 8 commits into from

Conversation

lucaspar
Copy link
Member

@lucaspar lucaspar commented May 2, 2025

SFDS-177

Gateway

  • Bugfix: Disconnecting older files from existing captures on update (bug caught by added integration tests on the SDK side).
  • Capture top-level directory is now normalized on creation and updates.
  • Removed the need to specify an absolute path.
    • As a result, the File post serializer now uses a common sanitization function for the path.
  • Moved factory-boy to base requirements to run tests in QA.

SDK

  • New tests to cover regressions of different kinds of path usage.
  • Bugfix: File.local_path attribute was not being set for some downloads.
  • Improved test for client.capture.read test: now it checks the number of files associated to the capture.
  • Better control over logging messages: client's verbose flag propagates to submodules and sub-APIs.

@lucaspar lucaspar added bug Something isn't working feature New feature or request refactoring General code improvements dependencies Pull requests that update a dependency file labels May 2, 2025
@lucaspar lucaspar requested a review from klpoland May 2, 2025 21:15
@lucaspar lucaspar self-assigned this May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file feature New feature or request refactoring General code improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant