Skip to content

Commit

Permalink
mth5 version 0.4.9 is out, fixing the crash in version 0.4.8. Updatin…
Browse files Browse the repository at this point in the history
…g pip install command in pyspedas CI script, log messages, and unit test.
  • Loading branch information
jameswilburlewis committed Oct 25, 2024
1 parent 5de1f44 commit eb9f064
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/pythonpackage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
pip install spacepy # required for MMS qcotrans tests
pip install coveralls
pip install basemap
pip install 'mth5<=0.4.7'
pip install 'mth5>=0.4.9'
python -m pyspedas.projects.mms.tests.setup_tests
if: matrix.os == 'ubuntu-latest'
- name: Install dependencies (Windows)
Expand All @@ -46,7 +46,7 @@ jobs:
pip install spacepy # required for MMS qcotrans tests
pip install coveralls
pip install basemap
pip install 'mth5<=0.4.7'
pip install 'mth5>=0.4.9'
python -m pyspedas.projects.mms.tests.setup_tests
if: matrix.os == 'windows-latest'
- name: Install dependencies (macOS)
Expand All @@ -60,7 +60,7 @@ jobs:
pip install spacepy # required for MMS qcotrans tests
pip install coveralls
pip install basemap
pip install 'mth5<=0.4.7'
pip install 'mth5>=0.4.9'
python -m pyspedas.projects.mms.tests.setup_tests
if: matrix.os == 'macos-latest'
- name: Lint with flake8
Expand Down
2 changes: 1 addition & 1 deletion pyspedas/mth5/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

except (ImportError, ModuleNotFoundError):
logging.error(f'MTH5 must be installed to use module {__name__}.')
logging.error("Please install it using: pip install 'mth5==0.4.7'")
logging.error("Please install it using: pip install mth5")
raise

# # Synchronize mth5 logging output level with pyspedas logging output level
Expand Down
2 changes: 1 addition & 1 deletion pyspedas/mth5/tests/test_mth5_import.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ def test_pyspedas_mth5_import_error(self):

# Verify the error log was called with the expected message
self.mock_logging_error.assert_any_call('MTH5 must be installed to use module pyspedas.mth5.')
self.mock_logging_error.assert_any_call("Please install it using: pip install 'mth5==0.4.7'")
self.mock_logging_error.assert_any_call("Please install it using: pip install mth5")


if __name__ == '__main__':
Expand Down

0 comments on commit eb9f064

Please sign in to comment.