-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud Awareness for PySPEDAS #1061
Conversation
…es for cleaner pr
Cloud Awareness for download.py
@jameswilburlewis The checks were not successful due to the MAVEN server being hit with too many requests. Let us know if there's anything you'd like us to do on our end regarding this PR. |
Resolved conflicting merged commit and reinstated Cloud Awareness for download.py. This should be ready to be incorporated now @jameswilburlewis |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me -- it might be tricky to get the full test suite to run because of MAVEN's data server rate limits, but at least the quick_tests are passing, which is reassuring. I think it's ready to merge.
Ah! Yea, I had issues with this as well but the tests for this specific implementation were written and tested using the HelioCloud data on an AWS VM. If there's questions later regarding any tests failing (beyond MAVEN's server-related limitations), feel free to ping. |
I did find one MAVEN bug introduced by the merge (now hopefully fixed in the master branch): when scraping the JPL NAIF index page to find MAVEN orbit files, the matching filenames weren't actually being added to the list to be downloaded, so anything that had to convert orbit numbers to times wouldn't work. Retests on github in progress now....fingers crossed! |
There was a similar MAVEN bug in get_l2_files_from_date(utilities.py): 924b4f3 Should be fixed now, retest in progress... |
All tests passing now! Next, I'll add the moto dependency and enable the new test suites in our github scripts. |
This is the completed PR that brings Cloud Awareness to PySPEDAS using the
fsspec
filesystem protocol (includes AWS and GCS support). The proposed changes do not break current API usage.Functionality/Summary:
SPEDAS_DATA_DIR
,local_data_dir
, orremote_data_dir
environment variables is required.force_download
option.moto
; dependency is not included in requirements.txt filemaven_load.py:543
.Dependencies:
This code was tested using AWS' CLI on an EC2 resource provided by the HelioCloud project. Details for setup and temporary credential management not included.
Finally, a separate contribution of a Jupyter notebook will be submitted to the
pyspedas_examples
repository for use with public AWS storage of mission data (e.g., from CDAWEB).closes #416