feat: add function to deal with yearly based file names #604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using `dailynames` for hour data could not resolve correctly
feat: function to deal with yearly based names
debug: OMNI hourly data
|
See Issue #603 |
Previous code miss the first file
remove debug part
|
Nice catch! Thanks for the fix. Our test script should have caught this one, but it wasn't noticed because data had been successfully loaded from an earlier test. I've updated the tests with some del_data calls, so hopefully we'll get a clean bill of health once the automated testing runs after this merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timespan of every year is not the same, so we need additional care when dealing with filename that are based on year.