Basic implementation of THM_SCPOT2DENS #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation includes tests and documentation.
This is initial implementation, there could be cases that are not validated yet. For example, new function works only with arrays, it does not process single values.
Also, THM_SCPOT2DENS is not the most updated function to calculate density from the spacecraft potential, but it is the most straightforward to convert, and it does have a crib sheet in SPEDAS. It was also initially recommended by Anderi Runov.
The branch
scpot2denwill be used for further development.Addressing #751