git checkouts fail with 'unable to connect to github.com'

[jrg1381]

Running the instructions in the repo fails with:

Command: git
Arguments: ls-remote --tags --heads git://github.com/shahata/jsdelivr-cdn-data.git
Directory: /usr/src/realtimewebclient
Output:
fatal: unable to connect to github.com:
github.com[0: 140.82.112.3]: errno=Connection timed out

which can be fixed by using https instead of git protocol.

It seems related to yarnpkg/yarn#6081.

[weakcamel]

How about replacing git:// -> https:// within the yarn.lock file?

I tried that and the connection problem is solved, but I fell into the pit of dependency anyway:

$ docker build -f Dockerfile.dev .
[+] Building 33.8s (9/9) FINISHED
 => [internal] load build definition from Dockerfile.dev                                                                                                                                               0.0s
 => => transferring dockerfile: 41B                                                                                                                                                                    0.0s
 => [internal] load .dockerignore                                                                                                                                                                      0.0s
 => => transferring context: 35B                                                                                                                                                                       0.0s
 => [internal] load metadata for docker.io/library/node:8                                                                                                                                              0.0s
 => [1/5] FROM docker.io/library/node:8                                                                                                                                                                0.0s
 => [internal] load build context                                                                                                                                                                      0.0s
 => => transferring context: 355.62kB                                                                                                                                                                  0.0s
 => CACHED [2/5] WORKDIR /usr/src/realtimewebclient                                                                                                                                                    0.0s
 => CACHED [3/5] COPY package.json .                                                                                                                                                                   0.0s
 => [4/5] COPY yarn.lock .                                                                                                                                                                             0.0s
 => ERROR [5/5] RUN yarn install && yarn cache clean                                                                                                                                                  33.5s
------
 > [5/5] RUN yarn install && yarn cache clean:
#9 1.105 yarn install v1.21.1
#9 1.349 [1/4] Resolving packages...
#9 2.014 [2/4] Fetching packages...
#9 3.639 warning [email protected]: Invalid bin entry for "r.js" (in "requirejs").
#9 29.02 warning [email protected]: Invalid bin field for "url-loader".
#9 30.99 warning [email protected]: Invalid bin entry for "sha.js" (in "sha.js").
#9 32.84 info [email protected]: The platform "linux" is incompatible with this module.
#9 32.84 info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
#9 32.85 error [email protected]: The engine "node" is incompatible with this module. Expected version ">=12". Got "8.17.0"
#9 32.87 error Found incompatible module.
#9 32.87 info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
------
executor failed running [/bin/sh -c yarn install && yarn cache clean]: exit code: 1

[jrg1381]

Yes, the dependencies are also broken now :-(

I figured that doing it in the Dockerfile would protect us in future against any new dependencies coming up which were git dependencies, but I'm not concerned which way we pick. Happy to change it in the yarn.lock file if you think that's better?

[weakcamel]

[...] doing it in the Dockerfile would protect us in future against any new dependencies coming up which were git dependencies

I'd be surprised if any new package was hosted on git:// URL but I guess it's not impossible. Either way is fine, I don't have a strong opinion.