fix logging and compile issues #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@spencerkimball can you please take a quick look? |
|
@bassam thank you so much for these updates. I hate to ask, but is there any way you could just remove the dependency on CockroachDB entirely and just simplify by using Go's base |
|
@spencerkimball ha! I started there and should've checked with you first. ok no prob. |
|
@spencerkimball note that we lose info, warn and error levels. you also lose color support I believe. do you care? |
|
No, logging for this isn't so busy those features are critical. |
|
@spencerkimball final had a chance to update this. let me know if you have any issues with it. |
bassam
force-pushed
the
pr-fix-logging
branch
from
cd3bd6a
to
acc1d68
Compare
bassam
force-pushed
the
pr-fix-logging
branch
from
acc1d68
to
2991505
Compare
|
Awesome. Thank you! I'll merge it now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed numerous compile issues with logging and errors. Also added strgazer_cache to .gitignore.
Addresses #5