-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n .since()
#110
Comments
Since
method not i18n friendly (other methods too?)
fair point - yeah I like that idea. i'm not sure it would be as easy as maybe it would need to be a function? I presume there's all sorts of cultural/lingustic gotchas rounded=i18nSince(rounded) open to PRs |
Righteo, will take a stab at it this weekend! 🤘 |
.since()
Is there any intention to move forward with this issue? Otherwise, we would be happy to present a solution. We look forward to hearing from you, thank you very much |
Hey Marc, I'm all ears! Feel free to take a crack at it. I don't know what linguistic considerations there are, but it should just involve moving the values through. Thanks for your help |
PR opened!! |
Seems like the
since
method's output is hardcoded to English?spacetime/src/methods/since.js
Line 132 in 8b93859
Any thoughts on allowing i18n as per the custom languages example?
The text was updated successfully, but these errors were encountered: