Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding timestamp on coins tab for easier utxo time sorting #9369

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wiederdev
Copy link

Choose utxo according to its age is now easier with this patch that adds ability to sort also with the utxo creation time.

@wiederdev
Copy link
Author

Does anyone understand what the regtest failure is all about? The patch is pretty simple, and I don't see how it is related to the failure.

@ecdsa
Copy link
Member

ecdsa commented Dec 17, 2024

Thanks for the PR. the regtest failure does not come from your commit, it also exists on master. I am investigating it.
EDIT: one particular regtest seems to be flaky since I introduced the constraint that payment should be MPP.

@ecdsa
Copy link
Member

ecdsa commented Dec 17, 2024

on my system, the window seems to need a manual resize in order to display the new column properly. not sure why..

@SomberNight
Copy link
Member

adds ability to sort also with the utxo creation time

you can already achieve the same sort order using the outpoint column though?

I don't really see the value in adding a date column.

If we made the columns configurable -- so that right clicking in the header would open a context menu allowing hiding/showing columns, then it would be easier to make the case to add more utility columns such as this. Without that, each column takes up space for everyone.

@wiederdev
Copy link
Author

I don't really see the value in adding a date column.

I live in a county which taxes the capital gains differently according to the date of purchase, and this way I could easily see the date of the utxo and know if it is relevant for selling.

If we made the columns configurable -- so that right clicking in the header would open a context menu allowing hiding/showing columns, then it would be easier to make the case to add more utility columns such as this. Without that, each column takes up space for everyone.

This would be perfect.
I am not sure how to do that, but on the history tab, there is a similar solution using a box on the top right where one can choose show/hide for some columns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants