Include EnablePersistentHookOverride option to control Persistent*Run override behavior #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bartdeboer
changed the title
bartdeboer
changed the title
bartdeboer
force-pushed
the
master
branch
2 times, most recently
from
f01c3f9
to
5420672
Compare
…ostRun* functions should override their parents
bartdeboer
changed the title
|
PR #1142 is perhaps a better approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Cobra will only run the last Persistent*Run functions that are defined within the command chain. This introduces an EnablePersistentHookOverride option which allows to run all the functions throughout the command chain.
Resolves: #252, #219
Related PR's: #714, #220